Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports of multiple databases in a single import file from influx -import #9423

Merged
merged 2 commits into from
Feb 9, 2018

Conversation

jsternberg
Copy link
Contributor

If multiple databases were specified, then the earlier writes would be
written to the later database and/or retention policy because points were
only written out after the batch size was reached. This forces the batcher
to flush whenever the database context switches.

Fixes #9336.

…t-export-import"

This reverts commit 9aeae7c, reversing
changes made to 35b44cc.

The contributor was unable to sign the contributor license agreement so
we have to revert this commit.
@ghost ghost assigned jsternberg Feb 9, 2018
@ghost ghost added the review label Feb 9, 2018
@hercules-influx
Copy link
Contributor

During a run of megacheck the following issues were discovered:

@jsternberg jsternberg changed the title Fix imports of multiple databases in a single import file Fix imports of multiple databases in a single import file from influx -import Feb 9, 2018
@jsternberg jsternberg force-pushed the js-9336-fix-imports-of-multiple-databases branch from 4343b8a to 4bc82c5 Compare February 9, 2018 16:04
@jsternberg jsternberg requested a review from rbetts February 9, 2018 16:04
@hercules-influx
Copy link
Contributor

During a run of megacheck the following issues were discovered:

@jsternberg
Copy link
Contributor Author

@rbetts this is a revert of a change where I didn't remember to check for the CLA before merging. The contributor couldn't figure out the policy for how to sign the CLA so I reverted his change and redid it. I think the main part of the code that was unique was the test case and the other parts in common are trivial (or were recommended by me to add during code review).

Copy link
Contributor

@rbetts rbetts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the change to comply with CLA.

…x -import`

If multiple databases were specified, then the earlier writes would be
written to the later database and/or retention policy because points
were only written out after the batch size was reached. This forces the
batcher to flush whenever the database context switches.
@jsternberg jsternberg force-pushed the js-9336-fix-imports-of-multiple-databases branch from 4bc82c5 to c58ca8d Compare February 9, 2018 16:33
@jsternberg jsternberg merged commit ef12d46 into master Feb 9, 2018
@ghost ghost removed the review label Feb 9, 2018
@jsternberg jsternberg deleted the js-9336-fix-imports-of-multiple-databases branch February 9, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants